Remove unused HostAxes._get_legend_handles.#20955
Merged
timhoffm merged 1 commit intomatplotlib:masterfrom Sep 1, 2021
Merged
Conversation
There's no call to a `_get_legend_handles` method anywhere in the codebase; conversely, the `legend._get_legend_handles` function explicitly handles host/parasite axes already.
QuLogic
approved these changes
Aug 31, 2021
timhoffm
approved these changes
Sep 1, 2021
tacaswell
pushed a commit
that referenced
this pull request
Oct 20, 2021
Remove unused HostAxes._get_legend_handles.
ericpre
pushed a commit
to ericpre/matplotlib
that referenced
this pull request
Oct 20, 2021
Remove unused HostAxes._get_legend_handles.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There's no call to a
_get_legend_handlesmethod anywhere in thecodebase; conversely, the
legend._get_legend_handlesfunctionexplicitly handles host/parasite axes already.
PR Summary
PR Checklist
pytestpasses).flake8on changed files to check).flake8-docstringsand runflake8 --docstring-convention=all).doc/users/next_whats_new/(follow instructions in README.rst there).doc/api/next_api_changes/(follow instructions in README.rst there).