TST: Add unit test to catch recurrences of #20822, #20855#20856
Closed
lpsinger wants to merge 1 commit intomatplotlib:masterfrom
Closed
TST: Add unit test to catch recurrences of #20822, #20855#20856lpsinger wants to merge 1 commit intomatplotlib:masterfrom
lpsinger wants to merge 1 commit intomatplotlib:masterfrom
Conversation
Contributor
Author
|
Note that the tests for this PR will be expected to fail until #20855 is merged. |
4df44f6 to
a5da792
Compare
7 tasks
a5da792 to
e0ae4b0
Compare
e0ae4b0 to
79a0a33
Compare
Contributor
Author
|
This should pass now that #20855 has been merged. |
tacaswell
approved these changes
Aug 20, 2021
Member
|
I cherry-picked this commit into #20857 for a belt-and-suspenders approach. |
Member
|
Merged into #20857. |
Member
|
Thanks @lpsinger ! I made the assumption you would not mind if we cherry-picked your commit to the other PR (and you are not counting merged PRs for a metric someplace), hope you are OK with this. |
Contributor
Author
|
Of course, no problem! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
Add a unit test to automatically catch issues like #20822 and #20855.
PR Checklist
pytestpasses).flake8on changed files to check).flake8-docstringsand runflake8 --docstring-convention=all).doc/users/next_whats_new/(follow instructions in README.rst there).doc/api/next_api_changes/(follow instructions in README.rst there).