Dedupe handling of mouse buttons in macos backend.#20778
Merged
greglucas merged 1 commit intomatplotlib:masterfrom Aug 3, 2021
Merged
Dedupe handling of mouse buttons in macos backend.#20778greglucas merged 1 commit intomatplotlib:masterfrom
greglucas merged 1 commit intomatplotlib:masterfrom
Conversation
AFAICT `mouseDown()` and friends already check `[event type]` and correctly handle right/middle button events, so the other event handlers can just defer to them. The point of the deduplication is so that future event rearchitecting doesn't have to repeat loads of keyboard-modifiers handling code in each of these handlers.
jkseppan
approved these changes
Aug 3, 2021
Member
jkseppan
left a comment
There was a problem hiding this comment.
Interactive zoom-out works on my Macbook Pro (I don't have a right mouse button but dragging with two fingers is equivalent).
greglucas
approved these changes
Aug 3, 2021
Contributor
greglucas
left a comment
There was a problem hiding this comment.
This also worked for me on macos. I had a right button that zoomed out as expected.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
AFAICT
mouseDown()and friends already check[event type]andcorrectly handle right/middle button events, so the other event handlers
can just defer to them.
The point of the deduplication is so that future event rearchitecting
(subsequent to #16931 and fixing #6159)
doesn't have to repeat loads of keyboard-modifiers handling code in each
of these handlers.
I don't actually have a mac to test this :-) so it would be nice if
someone could check if e.g. interactive zoom-out (by drawing a rubberband
with a right click) still works fine.
PR Summary
PR Checklist
pytestpasses).flake8on changed files to check).flake8-docstringsand runflake8 --docstring-convention=all).doc/users/next_whats_new/(follow instructions in README.rst there).doc/api/next_api_changes/(follow instructions in README.rst there).