Merged
Conversation
greglucas
approved these changes
Jun 23, 2021
Contributor
greglucas
left a comment
There was a problem hiding this comment.
Are the 20054-JMK filenames only used for organization/reference by the release manager, or do they need to be strictly associated with a PR#?
Member
|
Think I'll wait to see what happens with #20484 (comment) |
Member
|
I think this is probably reasonable, but #20501 will change this I think... |
It is not used at all anymore (its vertices are not even set correctly) since the switch to ColorbarAxes.
timhoffm
approved these changes
Jul 8, 2021
Member
|
Anybody can merge after CI pass |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It is not used at all anymore (its vertices are not even set correctly)
since the switch to ColorbarAxes.
PR Summary
PR Checklist
pytestpasses).flake8on changed files to check).flake8-docstringsand runflake8 --docstring-convention=all).doc/users/next_whats_new/(follow instructions in README.rst there).doc/api/next_api_changes/(follow instructions in README.rst there).