Fix positioning of annotation arrow.#19814
Merged
timhoffm merged 1 commit intomatplotlib:masterfrom Mar 30, 2021
Merged
Conversation
Reverts one change from 47f741e and adds a comment why it should not be removed. The choice of test to change might be a surprise, but most of our arrow-in-annotation tests use empty text, which would not trigger the bug. Changing this image has a much smaller effect than adding text to one of those would.
tacaswell
approved these changes
Mar 30, 2021
timhoffm
approved these changes
Mar 30, 2021
meeseeksmachine
pushed a commit
to meeseeksmachine/matplotlib
that referenced
this pull request
Mar 30, 2021
jklymak
added a commit
that referenced
this pull request
Mar 30, 2021
…814-on-v3.4.x Backport PR #19814 on branch v3.4.x (Fix positioning of annotation arrow.)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
Reverts one change from 47f741e and adds a comment why it should not be removed.
The choice of test to change might be a surprise, but most of our arrow-in-annotation tests use empty text, which would not trigger the bug. Changing this image has a much smaller effect than adding text to one of those would.
Fixes #19785.
PR Checklist
pytestpasses).flake8on changed files to check).flake8-docstringsand runflake8 --docstring-convention=all).doc/users/next_whats_new/(follow instructions in README.rst there).doc/api/next_api_changes/(follow instructions in README.rst there).