Skip to content

Fix resizing in nbAgg.#19746

Merged
jklymak merged 1 commit intomatplotlib:masterfrom
QuLogic:fix-nbagg-resize
Mar 22, 2021
Merged

Fix resizing in nbAgg.#19746
jklymak merged 1 commit intomatplotlib:masterfrom
QuLogic:fix-nbagg-resize

Conversation

@QuLogic
Copy link
Copy Markdown
Member

@QuLogic QuLogic commented Mar 19, 2021

PR Summary

The WebSocket wrapper around the IPython comm does not define readyState, and so resizes are never forwarded to the Python side.

PR Checklist

  • [n/a] Has pytest style unit tests (and pytest passes).
  • Is Flake 8 compliant (run flake8 on changed files to check).
  • [n/a] New features are documented, with examples if plot related.
  • [n/a] Documentation is sphinx and numpydoc compliant (the docs should build without error).
  • Conforms to Matplotlib style conventions (install flake8-docstrings and run flake8 --docstring-convention=all).
  • [n/a] New features have an entry in doc/users/next_whats_new/ (follow instructions in README.rst there).
  • [n/a] API changes documented in doc/api/next_api_changes/ (follow instructions in README.rst there).

@QuLogic
Fix resizing in nbAgg.
9cc0aac 
The WebSocket wrapper around the IPython comm does not define
`readyState`, and so resizes are never forwarded to the Python side.
@QuLogic QuLogic added Release critical For bugs that make the library unusable (segfaults, incorrect plots, etc) and major regressions. GUI: nbagg labels Mar 19, 2021
@QuLogic QuLogic added this to the v3.4.0 milestone Mar 19, 2021
@jklymak
Copy link
Copy Markdown
Member

jklymak commented Mar 22, 2021

How do we test this? Is this @ianhi issue?

@ianhi
Copy link
Copy Markdown
Contributor

ianhi commented Mar 22, 2021

Is this @ianhi issue?

@jklymak how do you mean?

I think this is a follow up to: #19131. In particular this commit: 725e908 which changed things in the webagg js which nbagg relies on.

How do we test this?

Run the UAT test in lib/matplotlib/backends/web_backend. Everything should still work ideally, and when manually resizing the figure should update.

One thing that I've been adding for lots of repos working with widgets is a github bot that comments on PRs with a binder link. In this case that link is:
https://mybinder.org/v2/gh/qulogic/matplotlib/fix-nbagg-resize?filepath=lib/matplotlib/backends/web_backend/nbagg_uat.ipynb

with the more general case described here: https://mybinder.readthedocs.io/en/latest/howto/gh-actions-badges.html

I'll bet that that script could be modified to check if any files in web_backend have been modified and then comment the appropriate binder link

ianhi
ianhi reviewed Mar 22, 2021
View reviewed changes
Comment thread lib/matplotlib/backends/web_backend/js/nbagg_mpl.js
ianhi
ianhi approved these changes Mar 22, 2021
View reviewed changes
Copy link
Copy Markdown
Contributor

@ianhi ianhi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense to me

@jklymak jklymak merged commit 9efccb3 into matplotlib:master Mar 22, 2021
@QuLogic QuLogic deleted the fix-nbagg-resize branch March 22, 2021 22:06
@tacaswell
Copy link
Copy Markdown
Member

tacaswell commented Mar 24, 2021

@meseeksdev backport to v3.4.x

@tacaswell
Copy link
Copy Markdown
Member

tacaswell commented Mar 24, 2021

@meeseeksdev backport to v3.4.x

@meeseeksmachine meeseeksmachine mentioned this pull request Mar 24, 2021
Merged
meeseeksmachine pushed a commit to meeseeksmachine/matplotlib that referenced this pull request Mar 24, 2021
@jklymak @meeseeksmachine
Backport PR matplotlib#19746: Fix resizing in nbAgg.
1239dd4
tacaswell added a commit that referenced this pull request Mar 24, 2021
@tacaswell
Merge pull request #19761 from meeseeksmachine/auto-backport-of-pr-19…
171f2bd 
…746-on-v3.4.x

Backport PR #19746 on branch v3.4.x (Fix resizing in nbAgg.)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tacaswell tacaswell tacaswell approved these changes

@jklymak jklymak jklymak approved these changes

+1 more reviewer

@ianhi ianhi ianhi approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

GUI: nbagg Release critical For bugs that make the library unusable (segfaults, incorrect plots, etc) and major regressions.

Projects

None yet

Milestone

v3.4.0

Development

Successfully merging this pull request may close these issues.

4 participants

@QuLogic @jklymak @ianhi @tacaswell