Don't update homebrew on GitHub Actions#19266
Merged
jklymak merged 2 commits intomatplotlib:masterfrom Jan 9, 2021
Merged
Conversation
This leaves us at the mercy of whenever Actions updates the formula database, but also prevents it from trying to update stuff in the image that we don't want it to update.
timhoffm
approved these changes
Jan 9, 2021
jklymak
approved these changes
Jan 9, 2021
meeseeksmachine
pushed a commit
to meeseeksmachine/matplotlib
that referenced
this pull request
Jan 9, 2021
timhoffm
added a commit
that referenced
this pull request
Jan 9, 2021
…266-on-v3.3.x Backport PR #19266 on branch v3.3.x (Don't update homebrew on GitHub Actions)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
This leaves us at the mercy of whenever Actions updates the formula database in the image, but also prevents it from trying to update stuff in the image that we don't want it to update.
Also, disable fail-fast.
PR Checklist
pytestpasses).flake8on changed files to check).flake8-docstringsand runflake8 --docstring-convention=all).doc/users/next_whats_new/(follow instructions in README.rst there).doc/api/next_api_changes/(follow instructions in README.rst there).