Skip to content

Move from cbook._warn_external() to _api.warn_external()#19144

Merged
timhoffm merged 2 commits intomatplotlib:masterfrom
timhoffm:change-warn_external_calls
Dec 18, 2020
Merged

Move from cbook._warn_external() to _api.warn_external()#19144
timhoffm merged 2 commits intomatplotlib:masterfrom
timhoffm:change-warn_external_calls

Conversation

@timhoffm
Copy link
Copy Markdown
Member

PR Summary

Followup of moving all API helpers to matplotlib._api (#18657).

Also use more f-strings in the warning messages to make them shorter more readable.

@timhoffm timhoffm force-pushed the change-warn_external_calls branch from 1c9c162 to 854de08 Compare December 18, 2020 00:04
@timhoffm timhoffm changed the title Move from cbook._warn_deprecated() to _api.warn_deprecated() Move from cbook._warn_external() to _api.warn_external() Dec 18, 2020
@timhoffm timhoffm added this to the v3.4.0 milestone Dec 18, 2020
@timhoffm timhoffm force-pushed the change-warn_external_calls branch from 854de08 to dc42bc8 Compare December 18, 2020 00:18
Comment thread lib/matplotlib/artist.py Outdated
Comment thread lib/matplotlib/backend_managers.py Outdated
@timhoffm timhoffm force-pushed the change-warn_external_calls branch from dc42bc8 to ae8af34 Compare December 18, 2020 01:13
Comment thread lib/matplotlib/figure.py Outdated
Copy link
Copy Markdown
Member

@jklymak jklymak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Feel free to self merge after committing @QuLogic suggestion!

Co-authored-by: Elliott Sales de Andrade <quantum.analyst@gmail.com>
@timhoffm timhoffm merged commit f23860d into matplotlib:master Dec 18, 2020
@timhoffm timhoffm deleted the change-warn_external_calls branch December 18, 2020 21:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants