Suppress -Wunused-function about _import_array when compiling tkagg.cpp.#19094
Merged
QuLogic merged 1 commit intomatplotlib:masterfrom Dec 12, 2020
Merged
Suppress -Wunused-function about _import_array when compiling tkagg.cpp.#19094QuLogic merged 1 commit intomatplotlib:masterfrom
QuLogic merged 1 commit intomatplotlib:masterfrom
Conversation
Member
|
The errors on windows look related to the PR? |
Per https://numpy.org/doc/1.17/reference/c-api.array.html#c.NO_IMPORT_ARRAY Other extension modules in Matplotlib already use the same mechanism.
Contributor
Author
|
Indeed :/ second try... |
dopplershift
approved these changes
Dec 11, 2020
Contributor
dopplershift
left a comment
There was a problem hiding this comment.
Seems reasonable, but I'm no expert.
QuLogic
approved these changes
Dec 12, 2020
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Per
https://numpy.org/doc/1.17/reference/c-api.array.html#c.NO_IMPORT_ARRAY
Other extension modules in Matplotlib already use the same mechanism.
PR Summary
PR Checklist
pytestpasses).flake8on changed files to check).flake8-docstringsand runflake8 --docstring-convention=all).doc/users/next_whats_new/(follow instructions in README.rst there).doc/api/next_api_changes/(follow instructions in README.rst there).