Always pass integers to wx.Size.#19052
Merged
tacaswell merged 1 commit intomatplotlib:masterfrom Dec 16, 2020
Merged
Conversation
Fixes test failure on Python 3.10, https://bugzilla.redhat.com/show_bug.cgi?id=1902382
dopplershift
approved these changes
Dec 1, 2020
Member
|
Why |
Contributor
(It would be nice to document once and for all how floating-point canvas sizes (which can legitimately occur e.g. with vector backends) are supposed to be handled by backends that only support integer sizes (typically raster backends).) |
Member
Author
|
Because that's what's already done here: matplotlib/lib/matplotlib/backends/backend_wx.py Lines 505 to 508 in ff15ca9 |
Member
Author
|
@meeseeksdev backport to v3.3.x |
meeseeksmachine
pushed a commit
to meeseeksmachine/matplotlib
that referenced
this pull request
Jan 27, 2021
tacaswell
added a commit
that referenced
this pull request
Jan 27, 2021
…052-on-v3.3.x Backport PR #19052 on branch v3.3.x (Always pass integers to wx.Size.)
3 tasks
This was referenced Mar 15, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
Fixes test failure on Python 3.10, https://bugzilla.redhat.com/show_bug.cgi?id=1902382
PR Checklist
pytestpasses).flake8on changed files to check).flake8-docstringsand runflake8 --docstring-convention=all).doc/users/next_whats_new/(follow instructions in README.rst there).doc/api/next_api_changes/(follow instructions in README.rst there).