Merged
Conversation
QuLogic
reviewed
Oct 7, 2020
timhoffm
reviewed
Oct 8, 2020
| with no replacement; ``gui_repaint`` now automatically detects the case where | ||
| it is used with the wx renderer. | ||
|
|
||
| The ``NavigationToolbar2Wx.get_canvas`` method is deprecated; copy its |
Member
There was a problem hiding this comment.
What's the motivation to deprecate this. Getting the canvas seems like a useful action, and type(toolbar.canvas)(frame, -1, figure) is pretty arcane.
Contributor
Author
There was a problem hiding this comment.
That method is not present on any of the other backends NavigationToolbar classes, and I'd rather try to make the NavToolbar API consistent across classes.
Member
There was a problem hiding this comment.
I would leave out type here, and use the explicit class instead.
QuLogic
approved these changes
Oct 13, 2020
| with no replacement; ``gui_repaint`` now automatically detects the case where | ||
| it is used with the wx renderer. | ||
|
|
||
| The ``NavigationToolbar2Wx.get_canvas`` method is deprecated; copy its |
Member
There was a problem hiding this comment.
I would leave out type here, and use the explicit class instead.
- Deprecate origin kwarg to wx gui_repaint(). It's really just a slightly obscure way to add a special-path for the (long deprecated) wx backend, which can be done more explicitly. - Deprecate unused NavigationToolbar2Wx.get_canvas.
Contributor
Author
|
sure |
timhoffm
approved these changes
Oct 13, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Deprecate origin kwarg to wx gui_repaint(). It's really just a
slightly obscure way to add a special-path for the (long deprecated)
wx backend, which can be done more explicitly.
Deprecate unused NavigationToolbar2Wx.get_canvas.
PR Summary
PR Checklist
pytestpasses).flake8on changed files to check).flake8-docstringsandpydocstyle<4and runflake8 --docstring-convention=all).doc/users/next_whats_new/(follow instructions in README.rst there).doc/api/next_api_changes/(follow instructions in README.rst there).