Change *subplot(111, ...) to *subplot(...) as 111 is the default.#18552
Merged
story645 merged 1 commit intomatplotlib:masterfrom Sep 24, 2020
Merged
Change *subplot(111, ...) to *subplot(...) as 111 is the default.#18552story645 merged 1 commit intomatplotlib:masterfrom
story645 merged 1 commit intomatplotlib:masterfrom
Conversation
story645
approved these changes
Sep 23, 2020
Member
story645
left a comment
There was a problem hiding this comment.
Some questions out of curiosity but they're not blockers
| ############################################################################### | ||
| # The `~.pyplot.figure` call here is optional because | ||
| # ``figure(1)`` will be created by default, just as a ``subplot(111)`` | ||
| # ``figure(1)`` will be created by default, just as a ``subplot()`` |
Member
Author
There was a problem hiding this comment.
No. I've rewritten the sentence to make more sense. But don't get me started, otherwise I'll rewrite the whole tutorial 😝.
44da50e to
52b7555
Compare
52b7555 to
4d6bba5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Partly re-does #17335.
Doing everything in one action seems a bit much since every occurrence must be checked. There some rare cases in which we want to leave the numbers in or want to do something else.
All changes are either in tutorials/examples, docstrings, comments or tests.