FIX: unit-convert pcolorargs before interpolating#18549
Merged
tacaswell merged 2 commits intomatplotlib:masterfrom Sep 23, 2020
Merged
FIX: unit-convert pcolorargs before interpolating#18549tacaswell merged 2 commits intomatplotlib:masterfrom
tacaswell merged 2 commits intomatplotlib:masterfrom
Conversation
d471a21 to
9a1af30
Compare
7c0711c to
9474ee6
Compare
9474ee6 to
75097a2
Compare
dopplershift
approved these changes
Sep 23, 2020
tacaswell
approved these changes
Sep 23, 2020
|
Owee, I'm MrMeeseeks, Look at me. There seem to be a conflict, please backport manually. Here are approximate instructions:
And apply the correct labels and milestones. Congratulation you did some good work ! Hopefully your backport PR will be tested by the continuous integration and merged soon! If these instruction are inaccurate, feel free to suggest an improvement. |
Member
Author
|
I can do the back port. Its a bit of a PITA because we changed the unit handling for 3.4 but not 3.3.x.... |
jklymak
pushed a commit
to jklymak/matplotlib
that referenced
this pull request
Sep 23, 2020
…t-before-interp FIX: unit-convert pcolorargs before interpolating
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
Closes #18547
For
pcolor(mesh)the new "nearest" interpolation was being done before unit conversion, so datetime (for instance) did not work. This moves unit conversion inside_pcolorargs.failed before, and works now...
PR Checklist
pytestpasses).flake8on changed files to check).flake8-docstringsandpydocstyle<4and runflake8 --docstring-convention=all).doc/users/next_whats_new/(follow instructions in README.rst there).doc/api/next_api_changes/(follow instructions in README.rst there).