DOC: reword non-monotonic cell center warning#18483
Merged
QuLogic merged 1 commit intomatplotlib:masterfrom Sep 15, 2020
Merged
DOC: reword non-monotonic cell center warning#18483QuLogic merged 1 commit intomatplotlib:masterfrom
QuLogic merged 1 commit intomatplotlib:masterfrom
Conversation
3 tasks
QuLogic
reviewed
Sep 14, 2020
48cc170 to
3ab4146
Compare
QuLogic
approved these changes
Sep 14, 2020
timhoffm
reviewed
Sep 15, 2020
Member
timhoffm
left a comment
There was a problem hiding this comment.
No very strong opinion, but here's another wording:
The input coordinates to {funcname} are interpreted as cell centers but are not monotonically increasing or decreasing. This may lead to wrongly calculated mesh cell edges. In such a case, please supply explicit cell edges to {funcname}.
3ab4146 to
a6640ce
Compare
Member
Author
|
Thanks @timhoffm - edited yours a bit, but that is better. |
Contributor
|
Doesn't look like you updated the expected text in the test? |
a6640ce to
8a54d4e
Compare
8a54d4e to
558ccae
Compare
Member
|
I pushed a fix to the tests, as this is the last thing for 3.3.2. |
dopplershift
approved these changes
Sep 15, 2020
meeseeksmachine
pushed a commit
to meeseeksmachine/matplotlib
that referenced
this pull request
Sep 15, 2020
QuLogic
added a commit
that referenced
this pull request
Sep 15, 2020
…483-on-v3.3.x Backport PR #18483 on branch v3.3.x (DOC: reword non-monotonic cell center warning)
Contributor
|
I like these wording changes, thanks for fixing that up! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
Slight modification to the warning in #18398.
PR Checklist
pytestpasses).flake8on changed files to check).flake8-docstringsandpydocstyle<4and runflake8 --docstring-convention=all).doc/users/next_whats_new/(follow instructions in README.rst there).doc/api/next_api_changes/(follow instructions in README.rst there).