Fix cibuildwheel trigger condition.#18233
Merged
QuLogic merged 6 commits intomatplotlib:masterfrom Aug 13, 2020
Merged
Conversation
Member
Author
|
Of course, now it's not running on pull requests, it doesn't show up here... |
Member
Author
|
I confirmed by pushing to master on my fork: https://github.com/QuLogic/matplotlib/actions/runs/206023557 |
Move the wheels to `dist` instead of `wheelhouse`, since that directory is ignored and git won't make the version `+dirty`.
Member
Author
|
I fixed a few more things I noticed: build against oldest supported NumPy, add PyPy (except Windows) and Python 3.6 wheels for 3.3.x, and fix the version tag. I tested out the Linux wheels which work with old NumPy, and I'm now testing out macOS wheels. |
Member
Author
meeseeksmachine
pushed a commit
to meeseeksmachine/matplotlib
that referenced
this pull request
Aug 13, 2020
QuLogic
added a commit
that referenced
this pull request
Aug 13, 2020
…233-on-v3.3.x Backport PR #18233 on branch v3.3.x (Fix cibuildwheel trigger condition.)
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
I believe this should be the right filters for what we want. It should build on master, tags, and backport branches, but not doc-backport branches.
PR Checklist