Fixes an issue where WxAgg NavigationToolbar2 broke custom toolbars#18219
Merged
dopplershift merged 1 commit intomatplotlib:masterfrom Aug 12, 2020
Merged
Fixes an issue where WxAgg NavigationToolbar2 broke custom toolbars#18219dopplershift merged 1 commit intomatplotlib:masterfrom
dopplershift merged 1 commit intomatplotlib:masterfrom
Conversation
…vigationToolbar2 would end up with buttons in the wrong place.
QuLogic
approved these changes
Aug 11, 2020
Member
QuLogic
left a comment
There was a problem hiding this comment.
LGTM, though I didn't really test it.
dopplershift
approved these changes
Aug 12, 2020
meeseeksmachine
pushed a commit
to meeseeksmachine/matplotlib
that referenced
this pull request
Aug 12, 2020
…olbar2 broke custom toolbars
dopplershift
added a commit
that referenced
this pull request
Aug 12, 2020
…219-on-v3.3.x Backport PR #18219 on branch v3.3.x (Fixes an issue where WxAgg NavigationToolbar2 broke custom toolbars)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
Fixes the issue in #18212 where the new coordinate readout in the WxAgg toolbar would lead to improper formatting when the toolbar was customized with additional buttons/widgets. To do so, this adds an optional coordinates keyword argument to the
NavigationToolbar2Wxthat ifTrue(default) shows the coordinate display and ifFalseremoves it.Buggy behavior (shows additional button on right):
Fixed behavior with
coordinates=False(shows additional button at the end of the standard buttons):PR Checklist