Skip to content

Correctly handle 'none' facecolors in do_3d_projection#18060

Closed
dstansby wants to merge 1 commit intomatplotlib:masterfrom
dstansby:rgba-fix
Closed

Correctly handle 'none' facecolors in do_3d_projection#18060
dstansby wants to merge 1 commit intomatplotlib:masterfrom
dstansby:rgba-fix

Conversation

@dstansby
Copy link
Copy Markdown
Member

@dstansby dstansby commented Jul 25, 2020

Fixes #18020.

Changes made in #17543 meant that _facecolor3d can now be an empty array, therefore make sure do_3d_projection only handles the case where the facecolor is set.

@dstansby dstansby changed the title Only handle len > 0 facecolors in do_3d_projection Correctly handle 'none' facecolors in do_3d_projection Jul 25, 2020
@dstansby dstansby added the Release critical For bugs that make the library unusable (segfaults, incorrect plots, etc) and major regressions. label Jul 25, 2020
@dstansby dstansby added this to the v3.3.1 milestone Jul 25, 2020
@tacaswell
Copy link
Copy Markdown
Member

tacaswell commented Jul 28, 2020

We might not have to backport this given that #17861 reverted the changes on v3.3.x?

@tacaswell
Copy link
Copy Markdown
Member

tacaswell commented Jul 28, 2020

#17850 is also relevant here?

@dstansby dstansby modified the milestones: v3.3.1, v3.4.0 Jul 30, 2020
@dstansby dstansby removed the Release critical For bugs that make the library unusable (segfaults, incorrect plots, etc) and major regressions. label Jul 30, 2020
@dstansby
Copy link
Copy Markdown
Member Author

dstansby commented Jul 30, 2020

@jklymak jklymak marked this pull request as draft August 24, 2020 15:18
@jklymak jklymak modified the milestones: v3.4.0, v3.4.1 Jan 27, 2021
@QuLogic
Copy link
Copy Markdown
Member

QuLogic commented Feb 19, 2021

#17850 was merged, so it looks like this needs to be changed to only include the test.

@QuLogic QuLogic modified the milestones: v3.4.1, v3.4.2 Mar 30, 2021
@dstansby
Copy link
Copy Markdown
Member Author

dstansby commented Apr 4, 2021

Looks like #18020 is closed, so I'm going to close this too.

@dstansby dstansby closed this Apr 4, 2021
@QuLogic
Copy link
Copy Markdown
Member

QuLogic commented Apr 6, 2021

Did you not want to keep the test?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@timhoffm timhoffm timhoffm approved these changes

Assignees

No one assigned

Labels

status: needs rebase status: needs revision status: waiting for other PR topic: mplot3d

Projects

None yet

Milestone

v3.4.2

Development

Successfully merging this pull request may close these issues.

Scatter3D: facecolor or color to "none" leads to an error

5 participants

@dstansby @tacaswell @QuLogic @timhoffm @jklymak