FIX: update num2julian and julian2num#18021
Conversation
9611ec8 to
cec46b5
Compare
|
Here is the render of the deprecation notice: https://41969-1385122-gh.circle-artifacts.com/0/doc/build/html/api/next_api_changes/deprecations/17983-JMK.html#functions-epoch2num-and-julian2num-use-rcparams-date-epoch-default-1970-01-01t00-00-00 Note that |
aa871f8 to
97d1685
Compare
timhoffm
left a comment
There was a problem hiding this comment.
Conditional on doc build fix.
Apply suggestions from code review Co-authored-by: Elliott Sales de Andrade <quantum.analyst@gmail.com>
9c20006 to
4757d98
Compare
|
Owee, I'm MrMeeseeks, Look at me. There seem to be a conflict, please backport manually. Here are approximate instructions:
And apply the correct labels and milestones. Congratulation you did some good work ! Hopefully your backport PR will be tested by the continuous integration and merged soon! If these instruction are inaccurate, feel free to suggest an improvement. |
…3.3.x Backport PR #18021: FIX: update num2julian and julian2num
PR Summary
I guess if
epoch2numshould be follow matplotlib epoch, thenjulian2numshould as well...Follow up to #17983
PR Checklist