Skip to content

API: resolve unset vmin / vmax in all ScalarMapple based methods#17859

Merged
efiring merged 1 commit intomatplotlib:masterfrom
tacaswell:fix_determintic_clim_autoscale
Jul 12, 2020
Merged

API: resolve unset vmin / vmax in all ScalarMapple based methods#17859
efiring merged 1 commit intomatplotlib:masterfrom
tacaswell:fix_determintic_clim_autoscale

Conversation

@tacaswell
Copy link
Copy Markdown
Member

@tacaswell tacaswell commented Jul 8, 2020 •
edited by dopplershift
Loading

PR Summary

See analysis in #17703

PR Checklist

  • Has Pytest style unit tests
  • Code is Flake 8 compliant
  • New features are documented, with examples if plot related
  • Documentation is sphinx and numpydoc compliant
  • Added an entry to doc/users/next_whats_new/ if major new feature (follow instructions in README.rst there)
  • Documented in doc/api/next_api_changes/* if API changed in a backward-incompatible way

@tacaswell tacaswell added the Release critical For bugs that make the library unusable (segfaults, incorrect plots, etc) and major regressions. label Jul 8, 2020
@tacaswell tacaswell added this to the v3.3.0 milestone Jul 8, 2020
@tacaswell tacaswell requested a review from timhoffm July 8, 2020 22:00
timhoffm
timhoffm approved these changes Jul 9, 2020
View reviewed changes
Copy link
Copy Markdown
Member

@timhoffm timhoffm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Modulo a fix in the API note.

Comment thread doc/api/prev_api_changes/api_changes_3.3.0/behaviour.rst Outdated
QuLogic
QuLogic reviewed Jul 9, 2020
View reviewed changes
Comment thread doc/api/prev_api_changes/api_changes_3.3.0/behaviour.rst Outdated
Comment thread doc/api/prev_api_changes/api_changes_3.3.0/behaviour.rst Outdated
@tacaswell tacaswell force-pushed the fix_determintic_clim_autoscale branch from 6286e1d to bd3fb17 Compare July 10, 2020 19:58
efiring
efiring approved these changes Jul 12, 2020
View reviewed changes
Copy link
Copy Markdown
Member

@efiring efiring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor typo, otherwise good.

Comment thread doc/api/prev_api_changes/api_changes_3.3.0/behaviour.rst Outdated
@tacaswell tacaswell force-pushed the fix_determintic_clim_autoscale branch from bd3fb17 to 267f1ea Compare July 12, 2020 22:46
@efiring efiring merged commit 97785f2 into matplotlib:master Jul 12, 2020
@meeseeksmachine meeseeksmachine mentioned this pull request Jul 12, 2020
Merged
meeseeksmachine pushed a commit to meeseeksmachine/matplotlib that referenced this pull request Jul 12, 2020
@efiring @meeseeksmachine
Backport PR matplotlib#17859: API: resolve unset vmin / vmax in all S…
0cf73fd 
…calarMapple based methods
@tacaswell tacaswell deleted the fix_determintic_clim_autoscale branch July 12, 2020 23:06
QuLogic added a commit that referenced this pull request Jul 13, 2020
@QuLogic
Merge pull request #17903 from meeseeksmachine/auto-backport-of-pr-17…
c899614 
…859-on-v3.3.x

Backport PR #17859 on branch v3.3.x (API: resolve unset vmin / vmax in all ScalarMapple based methods)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@QuLogic QuLogic QuLogic left review comments

@timhoffm timhoffm timhoffm approved these changes

@efiring efiring efiring approved these changes

@dstansby dstansby dstansby approved these changes

Assignees

No one assigned

Labels

Release critical For bugs that make the library unusable (segfaults, incorrect plots, etc) and major regressions.

Projects

None yet

Milestone

v3.3.0

Development

Successfully merging this pull request may close these issues.

QuadMesh.get_clim changed behavior in 3.3.0rc1

5 participants

@tacaswell @efiring @QuLogic @timhoffm @dstansby