Skip to content

More accurate handling of unicode/numpad input in gtk3 backends.#17791

Merged
timhoffm merged 1 commit intomatplotlib:masterfrom
anntzer:gtkkeys
Oct 8, 2020
Merged

More accurate handling of unicode/numpad input in gtk3 backends.#17791
timhoffm merged 1 commit intomatplotlib:masterfrom
anntzer:gtkkeys

Conversation

@anntzer
Copy link
Copy Markdown
Contributor

@anntzer anntzer commented Jun 29, 2020

See changelog.

PR Summary

PR Checklist

  • Has Pytest style unit tests
  • Code is Flake 8 compliant
  • New features are documented, with examples if plot related
  • Documentation is sphinx and numpydoc compliant
  • Added an entry to doc/users/next_whats_new/ if major new feature (follow instructions in README.rst there)
  • Documented in doc/api/api_changes.rst if API changed in a backward-incompatible way

@anntzer anntzer added this to the v3.4.0 milestone Jun 29, 2020
@anntzer anntzer force-pushed the gtkkeys branch 2 times, most recently from 0ef1c4a to 28f9312 Compare June 29, 2020 13:34
@QuLogic
Copy link
Copy Markdown
Member

QuLogic commented Jun 29, 2020

Interesting; some time back I tried to replace those magic numbers with GDK keysyms, but found that the numpad appeared to work backwards of numlock. I wonder if this will work correctly here.

@anntzer
Copy link
Copy Markdown
Contributor Author

anntzer commented Jun 29, 2020 •
edited
Loading

It works correctly locally (the numbers were just wrong in keyvald for numpad...), but CI seems unhappy...

timhoffm
timhoffm reviewed Jul 2, 2020
View reviewed changes
Comment thread doc/api/api_changes_3.4/behaviour.rst
@anntzer anntzer force-pushed the gtkkeys branch 2 times, most recently from baf3410 to 72f731f Compare July 2, 2020 20:36
@QuLogic
Copy link
Copy Markdown
Member

QuLogic commented Jul 18, 2020

CI doesn't like your test, it seems.

@anntzer
Copy link
Copy Markdown
Contributor Author

anntzer commented Jul 18, 2020

I know :/

@anntzer anntzer force-pushed the gtkkeys branch 2 times, most recently from af82f01 to 11e3ba8 Compare July 20, 2020 13:39
@QuLogic
Copy link
Copy Markdown
Member

QuLogic commented Jul 24, 2020

This fixes input via numpad for me.

@QuLogic QuLogic mentioned this pull request Aug 11, 2020
Open
@anntzer anntzer force-pushed the gtkkeys branch 2 times, most recently from 12f2543 to d9343e1 Compare September 10, 2020 11:16
@anntzer
Copy link
Copy Markdown
Contributor Author

anntzer commented Sep 10, 2020 •
edited
Loading

I decided to just skip the gtk test on travis for now...
Edit: the azure failure seems unrelated.

QuLogic
QuLogic reviewed Sep 12, 2020
View reviewed changes
Comment thread doc/api/next_api_changes/behavior/17791-AL.rst Outdated
Comment thread lib/matplotlib/tests/test_backend_gtk3.py
Comment on lines +36 to +35
# This is not actually really the right API: it depends on the
# actual keymap (e.g. on Azerty, shift+agrave -> 0).
Gtk.test_widget_send_key(fig.canvas, key, mod)
Copy link
Copy Markdown
Member

@QuLogic QuLogic Sep 12, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could this be why it's getting stuck? Maybe you can check len(buf) and assert the result after shutting down?

Copy link
Copy Markdown
Contributor Author

@anntzer anntzer Sep 12, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually turns out that even locally this is not passing anymore, i.e. calls to Gtk.test_widget_send_event (or Gdk.simulate_key_event) don't result in the key_press_event handler being called at all. At some point it worked, so likely a Gtk version thing? I just xfailed the whole thing for now...

Copy link
Copy Markdown
Member

@QuLogic QuLogic Sep 15, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

According to https://mail.gnome.org/archives/commits-list/2017-January/msg01173.html, those were never fully implemented (I only see an x11 version in that commit).

@anntzer anntzer force-pushed the gtkkeys branch 2 times, most recently from 4acfd3b to 7349d3e Compare September 12, 2020 10:36
@anntzer
Copy link
Copy Markdown
Contributor Author

anntzer commented Oct 8, 2020

rebased

@timhoffm timhoffm merged commit 2f0f7b4 into matplotlib:master Oct 8, 2020
@anntzer anntzer deleted the gtkkeys branch October 8, 2020 20:50
@anntzer anntzer mentioned this pull request Oct 8, 2020
Merged
7 tasks
@anntzer anntzer mentioned this pull request Feb 25, 2021
Merged
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@QuLogic QuLogic QuLogic approved these changes

@timhoffm timhoffm timhoffm approved these changes

Assignees

No one assigned

Labels

GUI: gtk

Projects

None yet

Milestone

v3.4.0

Development

Successfully merging this pull request may close these issues.

3 participants

@anntzer @QuLogic @timhoffm