Don't pass "wrong" indent=False in SVG generation.#17668
Merged
timhoffm merged 1 commit intomatplotlib:masterfrom Jun 18, 2020
Merged
Don't pass "wrong" indent=False in SVG generation.#17668timhoffm merged 1 commit intomatplotlib:masterfrom
indent=False in SVG generation.#17668timhoffm merged 1 commit intomatplotlib:masterfrom
Conversation
All kwargs to `XMLWriter.element()` are interpreted as XML attributes -- except the Falsy ones. So passing `indent=False` doesn't have any effect, but it's wrong to pass `indent` to `element()` anyways (e.g. passing `indent=True` would crash it instead of doing any indenting).
Member
|
It might make sense to extend the |
tacaswell
approved these changes
Jun 18, 2020
Contributor
Author
|
Not really, indenting is controlled by the parents... |
timhoffm
approved these changes
Jun 18, 2020
meeseeksmachine
pushed a commit
to meeseeksmachine/matplotlib
that referenced
this pull request
Jun 18, 2020
…G generation.
tacaswell
added a commit
that referenced
this pull request
Jun 18, 2020
…668-on-v3.3.x Backport PR #17668 on branch v3.3.x (Don't pass "wrong" `indent=False` in SVG generation.)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
All kwargs to
XMLWriter.element()are interpreted as XML attributes --except the Falsy ones. So passing
indent=Falsedoesn't have anyeffect, but it's wrong to pass
indenttoelement()anyways (e.g.passing
indent=Truewould crash it instead of doing any indenting).PR Summary
PR Checklist