constrained_layout rewrite....#17437
Closed
jklymak wants to merge 36 commits intomatplotlib:masterfrom
Closed
Conversation
6 tasks
Member
Author
|
Rebasing for this is going to be a big PITA because I have so much re-organization in |
Member
Author
|
Closing this for now in lieu of #17494 which doesn't have any of the changes to figure and subpanel. |
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
Just a draft for now, but this is meant to be substantially simpler than the current
constrained_layoutand more robust. Some of the flakiness should be gone. Colorbars are better located, and respect their anchors now.This version includes the idea of
figure.sub_panels, but that could be (reluctantly) taken out if its deemed not useful. It does get you nice things like:It wold have been nice to do them separately but it was pretty hard to make sure everything works for the nesting....
Most of the constrained_layout baseline images have changed, but thats because colorbar sizing has changed (for the better), and small changes to how padding is handled. I don't feel any of the choices made here make any of the images worse, and I don't think its worth trying to make them the same. I could be convinced to change a lot of these to assertions on the position of the axes, but its then a challenge to see what goes wrong if they break.
subpanel.PR Checklist