Skip to content

Unstale viewlims before draw()ing polar axes.#17422

Merged
QuLogic merged 1 commit intomatplotlib:masterfrom
anntzer:polarunstale
May 16, 2020
Merged

Unstale viewlims before draw()ing polar axes.#17422
QuLogic merged 1 commit intomatplotlib:masterfrom
anntzer:polarunstale

Conversation

@anntzer
Copy link
Copy Markdown
Contributor

@anntzer anntzer commented May 15, 2020

PR Summary

Closes #17418 (likely a regression in 3.2).

PR Checklist

  • Has Pytest style unit tests
  • Code is Flake 8 compliant
  • New features are documented, with examples if plot related
  • Documentation is sphinx and numpydoc compliant
  • Added an entry to doc/users/next_whats_new/ if major new feature (follow instructions in README.rst there)
  • Documented in doc/api/api_changes.rst if API changed in a backward-incompatible way

@anntzer anntzer added Release critical For bugs that make the library unusable (segfaults, incorrect plots, etc) and major regressions. topic: polar labels May 15, 2020
@anntzer anntzer added this to the v3.2.2 milestone May 15, 2020
@QuLogic
Copy link
Copy Markdown
Member

QuLogic commented May 15, 2020

Confirmed regression from v3.1.x.

@QuLogic
Copy link
Copy Markdown
Member

QuLogic commented May 15, 2020

Also, that last Azure job was cancelled, but not reporting to GitHub, so I can't restart it.

@tacaswell
Copy link
Copy Markdown
Member

tacaswell commented May 15, 2020

Restarted the job (side note, I don't understand the ACL model between GH and Azure).

I am not sure I understand why this change fixes things, but 👍 .

tacaswell
tacaswell approved these changes May 15, 2020
View reviewed changes
Copy link
Copy Markdown
Member

@tacaswell tacaswell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Anyone can merge on CI green.

@QuLogic
Copy link
Copy Markdown
Member

QuLogic commented May 16, 2020

Since you were wondering, this came from #13593, which made autoscaling lazy. The call to _unstale_viewLim is in AxesBase.draw, but obviously, that was missed to be added in PolarAxes.

@QuLogic QuLogic merged commit e70c6f8 into matplotlib:master May 16, 2020
@lumberbot-app
Copy link
Copy Markdown

lumberbot-app Bot commented May 16, 2020

Owee, I'm MrMeeseeks, Look at me.

There seem to be a conflict, please backport manually. Here are approximate instructions:

  1. Checkout backport branch and update it.
$ git checkout v3.2.x
$ git pull
  1. Cherry pick the first parent branch of the this PR on top of the older branch:
$ git cherry-pick -m1 e70c6f83be30076802398c6cf09b497077b4d1a8
  1. You will likely have some merge/cherry-pick conflict here, fix them and commit:
$ git commit -am 'Backport PR #17422: Unstale viewlims before draw()ing polar axes.'
  1. Push to a named branch :
git push YOURFORK v3.2.x:auto-backport-of-pr-17422-on-v3.2.x
  1. Create a PR against branch v3.2.x, I would have named this PR:

"Backport PR #17422 on branch v3.2.x"

And apply the correct labels and milestones.

Congratulation you did some good work ! Hopefully your backport PR will be tested by the continuous integration and merged soon!

If these instruction are inaccurate, feel free to suggest an improvement.

@anntzer anntzer deleted the polarunstale branch May 16, 2020 08:29
@tacaswell
Copy link
Copy Markdown
Member

tacaswell commented May 17, 2020

The call to _unstale_viewLim is in AxesBase.draw

Ah, that makes sense.

tacaswell pushed a commit to tacaswell/matplotlib that referenced this pull request May 17, 2020
@QuLogic @tacaswell
Merge pull request matplotlib#17422 from anntzer/polarunstale
a94a4ec 
Unstale viewlims before draw()ing polar axes.

Conflicts:
	lib/matplotlib/projections/polar.py
          - conflicts from nearyby changes to signature of draw
	lib/matplotlib/tests/test_polar.py
          - tests are still in test_axes.py on v3.2.x
tacaswell pushed a commit to tacaswell/matplotlib that referenced this pull request May 17, 2020
@QuLogic @tacaswell
Backport PR matplotlib#17422: Unstale viewlims before draw()ing polar…
404e0ff 
… axes.

Merge pull request matplotlib#17422 from anntzer/polarunstale

Unstale viewlims before draw()ing polar axes.

Conflicts:
	lib/matplotlib/projections/polar.py
          - conflicts from nearyby changes to signature of draw
	lib/matplotlib/tests/test_polar.py
          - tests are still in test_axes.py on v3.2.x
@tacaswell tacaswell mentioned this pull request May 17, 2020
Merged
dstansby added a commit that referenced this pull request May 18, 2020
@dstansby
Merge pull request #17435 from tacaswell/auto-backport-of-pr-17422-on…
391bb24 
…-v3.2.x

Backport PR #17422: Unstale viewlims before draw()ing polar axes.
@QuLogic QuLogic mentioned this pull request Jul 31, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tacaswell tacaswell tacaswell approved these changes

@QuLogic QuLogic QuLogic approved these changes

Assignees

No one assigned

Labels

Release critical For bugs that make the library unusable (segfaults, incorrect plots, etc) and major regressions. topic: polar

Projects

None yet

Milestone

v3.2.2

Development

Successfully merging this pull request may close these issues.

Issue rendering polar plot (agg backend?) with rorigin set

3 participants

@anntzer @QuLogic @tacaswell