Avoid creating a Tick in Axis.get_tick_space.#17348
Merged
timhoffm merged 2 commits intomatplotlib:masterfrom May 17, 2020
Merged
Avoid creating a Tick in Axis.get_tick_space.#17348timhoffm merged 2 commits intomatplotlib:masterfrom
timhoffm merged 2 commits intomatplotlib:masterfrom
Conversation
The `for` loop is supposed to check all fields in `kw` here, but `kw` does not change, so doing `kwargs.update(kw)` in the loop is a waste.
Member
|
This looks reasonable to me, if that is really a piece of code that slows things down. That tick-spacing heuristic is only a hack anyway. I'll be curious if all the tests pass, though. |
timhoffm
reviewed
May 16, 2020
Doing so is expensive, and triggers the figure to be marked stale. We don't need a whole tick, just the font size that it will eventually use, so calculate that directly.
5404ee7 to
222b3ba
Compare
timhoffm
approved these changes
May 17, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
Doing so is expensive, and triggers the figure to be marked stale. We don't need a whole tick, just the font size that it will eventually use, so calculate that directly.
Fixes #13971.
Also remove a redundant dictionary update.
PR Checklist