Merged
Conversation
anntzer
approved these changes
May 2, 2020
Member
Author
|
May as well get this in for 3.3 |
timhoffm
approved these changes
May 2, 2020
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
Closes #17304
An issue with CL is that zero-width axes are a solution to most of the constraints. The removed code in this PR was meant to prevent this collapse, but other changes later also do the same work (by adding a weak constraint to make the axes try to fill the figure. As #17304 shows, these lines are fragile for poorly constrained layouts.
Removing these lines still passes all the tests, passes the issue in #17304, and doesn't change any of the tutorial examples, so I think its fine.
PR Checklist