Skip to content

Changed return type of get_{x,y}ticklabels to plain list #17028

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
timhoffm merged 18 commits into from
Apr 13, 2020
Merged

Changed return type of get_{x,y}ticklabels to plain list #17028

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
18 commits
Select commit Hold shift + click to select a range
bd9d9aa
Changed return type of get_{x,y}ticklabels to plain list
SidharthBansal Apr 4, 2020
9b7e450
list typecasting
SidharthBansal Apr 4, 2020
3906e96
Added enhancement changes in behavior.rst
SidharthBansal Apr 4, 2020
56aaa50
removed axes
SidharthBansal Apr 5, 2020
d4b33bb
changed silent_list to list
SidharthBansal Apr 5, 2020
bd10208
removed _base.py changes
SidharthBansal Apr 5, 2020
d1a3f3e
Merge branch 'master' of https://github.com/matplotlib/matplotlib int…
SidharthBansal Apr 5, 2020
a6c0bf8
modified doc
SidharthBansal Apr 5, 2020
b26c92a
doc changes
SidharthBansal Apr 5, 2020
3491c72
Cross Referencing added
SidharthBansal Apr 5, 2020
07b4398
rectified constructor call
SidharthBansal Apr 5, 2020
352f688
Merge branch 'master' of https://github.com/matplotlib/matplotlib int…
SidharthBansal Apr 7, 2020
f95c76f
rebased
SidharthBansal Apr 7, 2020
d31f7a2
Update doc/api/api_changes_3.3/behaviour.rst
SidharthBansal Apr 7, 2020
005f32f
Update doc/api/api_changes_3.3/behaviour.rst
SidharthBansal Apr 7, 2020
4ff8ddb
Update doc/api/api_changes_3.3/behaviour.rst
SidharthBansal Apr 7, 2020
8179b2a
Sphinx edits
SidharthBansal Apr 7, 2020
399c61c
Merge branch 'master' into change_return_type_to_normal_list
SidharthBansal Apr 13, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 9 additions & 3 deletions doc/api/next_api_changes/behaviour.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -98,9 +98,9 @@ deprecation warning.
`~.Axes.errorbar` now color cycles when only errorbar color is set
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

Previously setting the *ecolor* would turn off automatic color cycling for the plot, leading to the
the lines and markers defaulting to whatever the first color in the color cycle was in the case of
multiple plot calls.
Previously setting the *ecolor* would turn off automatic color cycling for the plot, leading to the
the lines and markers defaulting to whatever the first color in the color cycle was in the case of
multiple plot calls.

`.rcsetup.validate_color_for_prop_cycle` now always raises TypeError for bytes input
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
Expand Down Expand Up @@ -155,3 +155,9 @@ support for it will be dropped in a future Matplotlib release.
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
Previously, keyword arguments were silently ignored when no positional
arguments were given.


`get_xticklabels` and `get_yticklabels` now returns plain list
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
Previously, get_xticklabels and get_yticklabels returns silent_list.
Copy link
Copy Markdown
Member

@tacaswell tacaswell Apr 4, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can enumerate all of the methods that will be changed? The audience for this will not have the context you current have. What are the consequences of this change? Who is likely to be affected? What can they do to get the old behavior back?

Copy link
Copy Markdown
Contributor Author

@SidharthBansal SidharthBansal Apr 4, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have two questions in my mind. 1st next_api_changes are the changes in the upcoming release which has not been shipped to market yet. Please correct me if I am wrong.
2nd: behaviour.rst is meant for knowing the changes across releases. Correct me if I am wrong.
thanks

They now return normal list.
6 changes: 3 additions & 3 deletions lib/matplotlib/axes/_base.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3406,7 +3406,7 @@ def get_xticklabels(self, minor=False, which=None):
which : None, ('minor', 'major', 'both')
Overrides *minor*.

Selects which ticklabels to return
Selects which ticklabels to return.

Returns
-------
Expand All @@ -3420,7 +3420,7 @@ def get_xticklabels(self, minor=False, which=None):

See also: `~.pyplot.draw` and `~.FigureCanvasBase.draw`.
"""
return self.xaxis.get_ticklabels(minor=minor, which=which)
return list(self.xaxis.get_ticklabels(minor=minor, which=which))

@cbook._make_keyword_only("3.3", "fontdict")
def set_xticklabels(self, labels, fontdict=None, minor=False, **kwargs):
Expand Down Expand Up @@ -3814,7 +3814,7 @@ def get_yticklabels(self, minor=False, which=None):

See also: `~.pyplot.draw` and `~.FigureCanvasBase.draw`.
"""
return self.yaxis.get_ticklabels(minor=minor, which=which)
return list(self.yaxis.get_ticklabels(minor=minor, which=which))

@cbook._make_keyword_only("3.3", "fontdict")
def set_yticklabels(self, labels, fontdict=None, minor=False, **kwargs):
Expand Down