Explicitly list allowed "unused" imports, remove the rest.#15210
Merged
jklymak merged 1 commit intomatplotlib:masterfrom Oct 1, 2019
Merged
Explicitly list allowed "unused" imports, remove the rest.#15210jklymak merged 1 commit intomatplotlib:masterfrom
jklymak merged 1 commit intomatplotlib:masterfrom
Conversation
175edc1 to
a7ccc22
Compare
QuLogic
approved these changes
Sep 8, 2019
Member
|
So why do those files keep their "unused" imports? |
Contributor
Author
|
Because they are effectively public API (you can import TextPath from matplotlib.text, even though you should really import it from matplotlib.textpath; or, for the constants in matplotlib._image, matplotlib.image is the public place from which you can import them). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
PR Checklist