FIX: un-break nightly wheels on py37#15033
Merged
tacaswell merged 1 commit intomatplotlib:masterfrom Aug 12, 2019
Merged
Conversation
Member
Author
|
marked as critical as without this the machinery we use to build the mac and linux wheels for 3.2 will not work. |
anntzer
reviewed
Aug 12, 2019
The issue is that matplotlib#14131 made our test suite fail on any warnings (good!), however we do not test all versions of numpy and `np.min([np.nan])` seems to warn for 1.14.4 < version < 1.15.0 which is not a range we test on travis. However, the version of numpy that the wheels pin to for py37 in 1.14.6 which does warn. This is likely related to numpy/numpy#10370
1df96ba to
07533e1
Compare
Member
Author
|
and rebased so hopefully the docs pass! |
anntzer
approved these changes
Aug 12, 2019
dstansby
approved these changes
Aug 12, 2019
Member
dstansby
left a comment
There was a problem hiding this comment.
Anyone can merge when/if CI all passes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The issue is that #14131
made our test suite fail on any warnings (good!), however we do not
test all versions of numpy and
np.min([np.nan])seems to warn for1.14.4 < version < 1.15.0 which is not a range we test on travis.
However, the version of numpy that the wheels pin to for py37 in
1.14.6 which does warn.
This is likely related to numpy/numpy#10370
PR Summary
PR Checklist