DOC: update axes_demo to directly manipulate fig, ax#14934
Merged
anntzer merged 2 commits intomatplotlib:masterfrom Aug 1, 2019
Merged
DOC: update axes_demo to directly manipulate fig, ax#14934anntzer merged 2 commits intomatplotlib:masterfrom
anntzer merged 2 commits intomatplotlib:masterfrom
Conversation
Directly call method on each individual axis; instead of the global ``plt.`` one, same to create inset; directly refer to the figure on which wee create an inset. I also use some more explicit renaming for each axis, and remove assignments on the LHS when those were unused as it seem like a distraction on the subject at hand.
jklymak
reviewed
Jul 31, 2019
Member
jklymak
left a comment
There was a problem hiding this comment.
Can this PR also make reference to ax.inset_axes and the axes grid one, just so folks have the other ways to do this automagically?
Contributor
Author
You mean Just refer to it in the leading text ? Or use them in the code. Can we use ":ref:" with examples ? |
Contributor
Author
|
To answer myself likely yes
|
Contributor
|
Prefer :doc: to :ref:, per #11312. |
Contributor
Author
Done. |
anntzer
approved these changes
Aug 1, 2019
meeseeksmachine
pushed a commit
to meeseeksmachine/matplotlib
that referenced
this pull request
Aug 1, 2019
meeseeksmachine
pushed a commit
to meeseeksmachine/matplotlib
that referenced
this pull request
Aug 1, 2019
Contributor
Author
|
Thanks. |
QuLogic
added a commit
that referenced
this pull request
Aug 1, 2019
…934-on-v3.1.1-doc Backport PR #14934 on branch v3.1.1-doc (DOC: update axes_demo to directly manipulate fig, ax)
QuLogic
added a commit
that referenced
this pull request
Aug 1, 2019
…934-on-v3.1.x Backport PR #14934 on branch v3.1.x (DOC: update axes_demo to directly manipulate fig, ax)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
Directly call method on each individual axis; instead of the global
plt.one, same to create inset; directly refer to the figure onwhich wee create an inset.
I also use some more explicit renaming for each axis,
and remove assignments on the LHS when those were unused as it seem like
a distraction on the subject at hand.
PR Checklist