Fix locator/formatter setting when removing shared Axes#13983
Merged
tacaswell merged 2 commits intomatplotlib:masterfrom Apr 20, 2019
Merged
Fix locator/formatter setting when removing shared Axes#13983tacaswell merged 2 commits intomatplotlib:masterfrom
tacaswell merged 2 commits intomatplotlib:masterfrom
Conversation
timhoffm
approved these changes
Apr 19, 2019
Member
|
Thanks! To some degree this is adding epicycles to an already overly-complicated system, but the full re-write is not imminent so this is the practical thing to do. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a shared Axes was removed from a plot, any other Axes it was shared with had their Axis locators/formatters set to the locator/formatter on the removed Axes. This PR makes sure that setting only happens if the locator/formatter has previously been manually set. This allows the locator/formatter to be automatically set in the future by e.g. units being plotted.
Fixes #12853