When linking against libpng/zlib on Windows, use upstream lib names.#13084
Merged
tacaswell merged 1 commit intomatplotlib:masterfrom Jun 24, 2019
Merged
Conversation
Member
|
We should also check if this will have an impact on conda-forge |
74b8a16 to
aba8901
Compare
Contributor
Author
|
Likely also needed for #13077 unless one wants to also write the manual renaming for azure. |
Member
|
I'm going to close this as it has been folded into #13077 |
6 tasks
See changelog for details.
aba8901 to
d6aeade
Compare
Contributor
Author
|
Reopening as #13077 doesn't appear close to being merged and the nonstandard names are still confusing (#14355 (comment)). |
timhoffm
approved these changes
Jun 4, 2019
Member
|
Not yet merging because the second approval was long ago. @tacaswell is your approval still valid? |
Member
|
This may conflict with the patches conda applies: https://github.com/conda-forge/matplotlib-feedstock/blob/master/recipe/setupext.patch |
Contributor
|
LGTM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See changelog for details.
Should fix the symptoms (failure to link png.lib) of #13016 (@rth, can you confirm?).
Implements part of #9693; the static/dynamic switch proposed there could be added later.
PR Summary
PR Checklist