Prepare for ipython 7.1 stricter ipython directive.#12587
Closed
Carreau wants to merge 1 commit intomatplotlib:masterfrom
Closed
Prepare for ipython 7.1 stricter ipython directive.#12587Carreau wants to merge 1 commit intomatplotlib:masterfrom
Carreau wants to merge 1 commit intomatplotlib:masterfrom
Conversation
In 7.1 the IPython directive will be stricter about unexpected error/warnings _by default_ and will stop the build. This can be disabled globally with ipython_warn_is_error, or on a per-block basis by setting the appropriate `:okwarning:`/`okexcept` I was only able to go that far as other things were preventing me from finishing the build (some document not included in any toctree), but at least this is one less error.
Member
|
This is related to #12583 |
dstansby
reviewed
Oct 22, 2018
| @@ -37,6 +37,7 @@ The upshot of this is that for interactive backends (including | |||
| ``%matplotlib notebook``) in interactive mode (with ``plt.ion()``) | |||
|
|
|||
| .. ipython :: python | |||
Member
There was a problem hiding this comment.
I wonder if we should just have this as a code markup block, and not an ipython block? Otherwise we're just trying to keep code from MPL 1.5 running on new versions of MPL.
Contributor
Author
There was a problem hiding this comment.
That would be fine for me too, but that will removed the rendered plot.
You could also set to :verbatim: so it won't try to process.
Member
There was a problem hiding this comment.
I'm not sure it's all that important to see the plot in this specific case.
Member
There was a problem hiding this comment.
Indeed, because you can not see it change!
Contributor
Author
|
In *this* case, sure. But in general I'm sure other places in the docs will
fail and would need fixing :-)
…On Mon, Oct 22, 2018, 18:31 Thomas A Caswell ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In doc/users/prev_whats_new/whats_new_1.5.rst
<#12587 (comment)>
:
> @@ -37,6 +37,7 @@ The upshot of this is that for interactive backends (including
``%matplotlib notebook``) in interactive mode (with ``plt.ion()``)
.. ipython :: python
Indeed, because you can not see it change!
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#12587 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAUez8ZTdtRhXWpN9ZJtsIEM01MxRZTnks5unnF_gaJpZM4XyzaC>
.
|
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In 7.1 the IPython directive will be stricter about unexpected
error/warnings by default and will stop the build.
This can be disabled globally with ipython_warn_is_error,
or on a per-block basis by setting the appropriate
:okwarning:/:okexcept:I was only able to go that far as other things were preventing me from
finishing the build (some document not included in any toctree),
but at least this is one less error.
Also this should give you a heads up, that IPython 7.1 should be released soon-ish (I hope end of week as it introduce some fixes and compatibility with Python 3.7.1, that if all build breaks it will likely not be your fault.