Deprecate nbagg.transparent rcParam.#10024
Merged
dstansby merged 1 commit intomatplotlib:masterfrom Dec 23, 2017
Merged
Conversation
Member
|
If a user includes |
ee329e8 to
0dd9096
Compare
Contributor
Author
|
Sounds good, fixed. |
jklymak
approved these changes
Dec 19, 2017
Member
jklymak
left a comment
There was a problem hiding this comment.
This looks good to me. It works w/ jupyter, though I didn't have that rcparam set of course...
dstansby
approved these changes
Dec 23, 2017
efiring
added a commit
to efiring/matplotlib
that referenced
this pull request
Jan 15, 2018
In matplotlib#10024, rcParams['nbagg.transparent'] was marked as deprecated and ignored, but it was not removed from backend_nbagg. As a result, every plot made with backend_nbagg was raising a warning. This PR finishes matplotlib#10024 by removing the reference and the line that depends on it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See rationale in #8654, also discussion in #5419.
Unlike for #10023 I am not sure of the best way to handle the deprecation, as this is a change of defaults (from transparent to nontransparent), so the deprecation warning doesn't really help before the default is changed, but it's too late after...
PR Summary
PR Checklist