Update Definitions.py to match API Docs - #44
Closed
Gilgahex wants to merge 1 commit into
Closed
Conversation
after_hours -> afterHours
Collaborator
|
This was done intentionally to follow Python's coding style of snake casing. This dictionary maps the api response attribute names to conventional Python names. |
Author
|
For the sake of consistency then shouldn't preMarket be pre_market |
Collaborator
@Gilgahex You are right it is currently inconsistent. I will make a new PR addressing this and will let you know when that's up. |
Collaborator
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I was surprised to find that the API Docs are a little off
A simple update find and replace for
after_hours -> afterHours