Skip to content

onAppStart event for iOS. - #574

Merged
2 commits merged into
release-2.0.0from
bugfix/onAppStart_iOS
Apr 29, 2020
Merged

onAppStart event for iOS.#574
2 commits merged into
release-2.0.0from
bugfix/onAppStart_iOS

Conversation

@ghost

@ghost ghost commented Apr 29, 2020

Copy link
Copy Markdown

No description provided.

@ghost ghost added the iOS Related to iOS platform. label Apr 29, 2020
@ghost ghost added this to the 2020.Q1 milestone Apr 29, 2020
@ghost
ghost requested a review from pleszkiewicz April 29, 2020 09:22
@ghost ghost self-assigned this Apr 29, 2020

@pleszkiewicz pleszkiewicz left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code: 👍

RCT_EXPORT_METHOD(addChildNodeToContainer:(NSString *)nodeId) {
ARLog(@"addChildNodeToContainer: %@", nodeId);
[NodesManager.instance addNodeToRoot:nodeId];
self.shouldSendInitialURI = true;

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should be YES :)

}
Scene *scene = NodesManager.instance.scene;
[[AREventsManager instance] onAppStartEventReceived:scene initialUri:initialUri];
self.shouldSendInitialURI = false;

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

false -> NO

@ghost
ghost merged commit a5d3d9e into release-2.0.0 Apr 29, 2020
@ghost
ghost deleted the bugfix/onAppStart_iOS branch April 29, 2020 10:47
darek607 pushed a commit that referenced this pull request May 4, 2020
* [Dialog] Properly hide label (#573)

fixes #563

* fixed non-existing planeType key exception, refactor (#571)

* onAppStart event for iOS. (#574)

* Initial implementation.
* Post review fixes.

* timer and date picker fixes (#575)

* text wrapping fix (#576)

* Update way of handling initial url. (#577)

* bigger accepted outside touch offset (#578)

* Hotfix/Dialog fixes (#581)

* dialogs fixes and refactor

* test fix

* Bump the ver. to 2.0.0

Co-authored-by: Grzegorz Dec <grzegorz.dec@blstream.com>
Co-authored-by: Sebastian Paluchiewicz <42351184+SPaluchiewiczSofomo@users.noreply.github.com>
Co-authored-by: Paweł Leszkiewicz <pleszkiewicz@users.noreply.github.com>
Co-authored-by: Nikolay Grozdanov <ngrozdanov@magicleap.com>
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

iOS Related to iOS platform.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants