fix(db): reject cyclic class inheritance imports#12903
Open
megayu wants to merge 2 commits into
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds cycle detection for class inheritance (:build/class-extends) during SQLite build transactions, preventing invalid ontology imports that would create cyclic class graphs (per db-test issue #998).
Changes:
- Added a pre-build validation step to reject cycles in
:build/class-extendsgraphs. - Added new tests covering self-cycle, multi-class cycle, and a valid diamond-shaped inheritance graph.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| deps/db/src/logseq/db/sqlite/build.cljs | Adds :build/class-extends cycle validation and invokes it during build-blocks-tx*. |
| deps/db/test/logseq/db/sqlite/build_test.cljs | Adds regression tests ensuring cyclic inheritance is rejected and non-cyclic inheritance succeeds. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix logseq/db-test#998