Skip to content

refactor: rename silence domain language to room tone#96

Merged
flexiondotorg merged 2 commits into
mainfrom
room-tone
May 26, 2026
Merged

refactor: rename silence domain language to room tone#96
flexiondotorg merged 2 commits into
mainfrom
room-tone

Conversation

@flexiondotorg
Copy link
Copy Markdown
Contributor

Systematic rename across processor, logging, and CLI domains reflecting product terminology alignment. Affects types (SilenceRegion → RoomToneRegion), functions, CLI flags (--room-tone-scan-duration), JSON keys, comments, and documentation. Behaviour-preserving: no changes to thresholds, scoring, filter order, pass orchestration, or audio output.

Changes:

  • Domain model types and functions (SilenceRegion/detection/scoring)
  • CLI flags with deprecated aliases for backwards compatibility
  • JSON marshal/unmarshal keys (backwards compatible via compatibility shim)
  • Processor adaptive config and speech boundary wording
  • Reporting diagnostics, metrics labels, and recording tips
  • Documentation (README, AGENTS, filter design notes)
  • Test names and script variables

Systematic rename across processor, logging, and CLI domains reflecting
product terminology alignment. Affects types (SilenceRegion →
RoomToneRegion), functions, CLI flags (--room-tone-scan-duration), JSON
keys, comments, and documentation. Behaviour-preserving: no changes to
thresholds, scoring, filter order, pass orchestration, or audio output.

Changes:
- Domain model types and functions (SilenceRegion/detection/scoring)
- CLI flags with deprecated aliases for backwards compatibility
- JSON marshal/unmarshal keys (backwards compatible via compatibility
  shim)
- Processor adaptive config and speech boundary wording
- Reporting diagnostics, metrics labels, and recording tips
- Documentation (README, AGENTS, filter design notes)
- Test names and script variables

Signed-off-by: Martin Wimpress <code@wimpress.io>
Copy link
Copy Markdown
Contributor

@cubic-dev-ai cubic-dev-ai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 38 files

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

Requires human review: This is a large-scale rename refactor affecting 38 files and 2018 lines; while behaviour-preserving, refactors of this size and scope carry risk of missed renames or subtle inconsistencies that warrant a human review.
Tip: cubic can generate docs of your entire codebase and keep them up to date. Try it here.

Re-trigger cubic

- Update Benchmarks.md to reference room tone instead of silence in
  parity analysis
- Clarify DS201 Gate responsibility as room-tone-aware in LA-2A filter
  guide
- Rename threshold comments in analyzer_candidates_room_tone.go for
  consistency

Signed-off-by: Martin Wimpress <code@wimpress.io>
Copy link
Copy Markdown
Contributor

@cubic-dev-ai cubic-dev-ai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

0 issues found across 3 files (changes from recent commits).

Requires human review: This large-scale rename refactor across 2044 lines touches core types, CLI, and serialization paths; even with claimed backward compatibility, the blast radius and risk of missed renames or shim errors warrant a human review.

Re-trigger cubic

@flexiondotorg flexiondotorg merged commit 37a3bca into main May 26, 2026
16 checks passed
@flexiondotorg flexiondotorg deleted the room-tone branch May 26, 2026 11:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant