[WIP] feat(format): allow custom partition layout specification in linuxkit format #4104
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…/format Signed-off-by: Yoshi Jaeger <github@jaeger.berlin>
70bf958 to
7e51543
Compare
Signed-off-by: Yoshi Jaeger <github@jaeger.berlin>
Collaborator
|
This makes sense. You are saying that the partition command used is In that case, can it be documented and an example provided?
|
Author
|
Yeah this was the goal! I would have edited exactly this documentation without you pointing it out! 🙂 I need to work out the specifics and I am currently checking whether the tooling is working as expected. It looks good so far! |
7e51543 to
d517779
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
- What I did
Add an option to
linuxkit/formatthat allows specifying multiple partitions.- How I did it
I modified the
format.gosource code by adding apartitionLayoutVarthat allows specifying a different value than ";" (create one partition)- How to verify it
/usr/bin/format --layout "size=20M,type=83\nsize=30M,type=83\n" /dev/vdashould create two partition.
This PR is a WIP because I still have to verify this in my production setup.
- Description for the changelog
allow specification of partition layout in linuxkit/format
- A picture of a cute animal (not mandatory but encouraged)
