Add patches for 7.1 - #2178
Conversation
Derived from latest 7.0 patches
Based on the current v7.0 config
|
Surface Laptop Studio 1 : no issue to report, no issue |
Hi @Apiznel . These changes are more numerous and varied in their nature as a single PR, and harder to discern one from the other, as compared with your previous similar PRs. Especially considering they are distilled into patch files, which in turn patch multiple files. Are you rebasing from a clone of surface 'kernel' project somewhere, where these changes are easier to read? For example in my case I'm trying to understand what conflict needed to be addressed for the rebasing this time around, just a change in the offset for where the patched are applied, or something more functional? |
|
@orthogonaleety I don't see how these are different from my previous pull requests? If you could elaborate/give examples, that would be appreciated. In regards to reviewing, I don't know how you're approaching it. I do have a local kernel repo (not of the linux-surface one) although that wouldn't be any more readable. You could diff my patches from 7.0 to 7.1. Do note that I did rebase 7.0 for the same context change as with |
|
...
You're quite right. I hadn't noticed for example this comment in the past. So I assumed when I saw your comments above that there was more to it this time. (I have used the diff method you mention on the patches patches previously, but that was just when I was anticipating them to be just context/offset changes..) Many thanks Apiznel |
I have tested with the patch on my Surface Laptop Studio 1, don't see any issue |
|
Tests good for me for 7.1.3 , Surface Pro 8, (fedora 44) (for f44 would need this cherry picking among other outstanding PRs, orthogonaleety@a0b81c4) |
Correct IPTS_HID_REPORT_DATA_SIZE out by 3 bytes Investigating an issue linux-surface#2150 change in kernel hid-core torvalds/linux@0a3fe97 "remove the memset() and simply return if the incoming event buffer size is not large enough" Causes a problem between incorrect sizing of IPTS_HID_REPORT_DATA_SIZE used with hid_input_report which does not agree with the hid device's authoritative setup with ipts_fallback_descriptor[] It appears that Report ID (1 byte) and the Scan Time (2 bytes) where missed in the accounting.
fix kernel error for EDS1 type surface devices & update context 0013-cameras.patch
|
7.1.5, Surface Laptop Studio 2, Fedora 43 - So far no issues :) |
|
Tested 7.1.1-7.1.7 on Arch, Surface Pro 9 - all working perfectly |
|
Surface Pro 8 with 7.1.5 on Arch Linux. Rear camera works well. Had to patch the patch as the rear camera image was upside down by default. Rotated 180 degrees and now it works. Quality isn't that great. Better than nothing. |
|
Tested 7.1.8 on AnduinOS, SurfaceBook 2, the front camera works fine, though the image quality seems a bit low, the rear camera shows a green screen. All other functions are working normally. ;) |
Rebased
0005-ipts.patch,0009-surface-button.patch, and0013-cameras.patchbecause of:Removed
0015-rtc.patchbecause upstream does something similar: