Skip to content

added a direct method for creating a qrcode.png from a string#1

Closed
becker990 wants to merge 1 commit into
lincolnloop:masterfrom
becker990:master
Closed

added a direct method for creating a qrcode.png from a string#1
becker990 wants to merge 1 commit into
lincolnloop:masterfrom
becker990:master

Conversation

@becker990
Copy link
Copy Markdown

No description provided.

@SmileyChris
Copy link
Copy Markdown
Member

Creating a shortcut method is definitely a worthy end-goal.

I'd say it may be better to just have a simple function for creating the PIL image, and then let the user save that (or do whatever other PIL transformations are required) rather than just saving it outright.

What do you think about that?

@SmileyChris
Copy link
Copy Markdown
Member

Here's the shortcut, anyway. It should suffice

@becker990
Copy link
Copy Markdown
Author

Hey!

Hi! I wanna apologize for being so late on it!
I have been very busy using this on another project... =P

But before, the thing is... this was my first pull request and i was
expecting to be complete ignored
but you have been an example for the open source community!
u were a very cool person with me (polite friendly and open)
and i am very happy for it!

anyway talking is easy, to the code!
the case is that your shortcut is good and mine was more or less
a shortcut that solved only a specific case
your way it is much more flexible, therefore i am pulling it

really thanks!

@SmileyChris
Copy link
Copy Markdown
Member

I do let some of my project's issues/pull requests lag a bit, but try to keep on top of things. Thanks for your encouraging words and I hope you continue frequent interactions with open source projects. Talk maybe cheap, but it can get people inspired :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants