ci: run real studio e2e prep with bash - #81
Merged
Conversation
✅ Deploy Preview for limitless-angular-sanity-example canceled.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Checklist
Fixes the main CI failure in
presentation-e2ewhere thePrepare real-project Sanity Studio E2Estep runs undershinside the Playwright container and fails on Bash indirect expansion withBad substitution.Closes N/A
What is the new behavior?
The real-project Studio E2E preparation step now explicitly runs with Bash, so the existing
${!name}secret-presence check is evaluated by the shell it was written for.Does this PR introduce a breaking change?
No breaking change. This only updates the CI workflow shell for one preparation step.
Other information
Validation performed:
bash -c 'missing=0; for name in SANITY_E2E_PROJECT_ID SANITY_E2E_DATASET SANITY_E2E_READ_TOKEN SANITY_E2E_BYPASS_TOKEN SANITY_E2E_STORAGE_STATE_JSON; do if [ -z "${!name}" ]; then missing=1; fi; done; test "$missing" -eq 1'pnpm exec prettier --check .github/workflows/ci.ymlgit diff --check[Optional] What gif best describes this PR or how it makes you feel?
N/A