Skip to content

build: update node toolchain to 24.17.0 - #79

Merged
osnoser1 merged 7 commits into
mainfrom
osnoser1/replicate-cianz-pr-32-node-24
Jun 21, 2026
Merged

build: update node toolchain to 24.17.0#79
osnoser1 merged 7 commits into
mainfrom
osnoser1/replicate-cianz-pr-32-node-24

Conversation

@osnoser1

@osnoser1 osnoser1 commented Jun 21, 2026

Copy link
Copy Markdown
Member

PR Checklist

No linked issue.

What is the new behavior?

  • Replicates osnoser1/cianz-web#32 for this monorepo by adding volta.extends to nested workspace package manifests so commands inherit the root toolchain.
  • Updates the repo Node runtime pins to 24.17.0 across .nvmrc, root Volta config, root engines, pnpm-workspace.yaml, Netlify config, and contributor docs.
  • Replicates osnoser1/cianz-web#35 with devEngines.runtime pinned to Node 24.17.0, plus node@runtime:24.17.0 lockfile metadata so pnpm node and pnpm exec node use the pinned runtime.
  • Updates direct @types/node specs to ~24.13.2 and refreshes pnpm-lock.yaml.
  • Fixes the Node 24 CI hang by running Playwright-dependent PR jobs in the official mcr.microsoft.com/playwright:v1.44.1-jammy image, removing playwright install --with-deps from GitHub-hosted runners, trusting the checked-out workspace inside containers, and passing PLAYWRIGHT_BROWSERS_PATH=/ms-playwright through Turbo.
  • Replaces the generated Angular compatibility runtime smoke test with a direct Node/Playwright runner that owns the server lifecycle, avoiding opaque Playwright Test webServer hangs inside the generated consumer.
  • Keeps the Playwright fix deterministic instead of timeout-based: the workflow contract asserts those jobs do not carry timeout-minutes workarounds.

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

CI diagnosis:

  • The original stuck jobs were blocked in Playwright browser installation, not in package build/test code.
  • The same hang appeared before the devEngines.runtime commit, so the runtime metadata was not the root cause.
  • The Angular compatibility matrix resolves to Angular 20, 21, 22, and next rows that accept Node 24.17.0; this was not an Angular/Node version incompatibility.
  • After removing the browser-install hang, the generated Angular consumer smoke runner was simplified so startup, browser launch, page assertions, and cleanup are handled directly in one generated Node script.

Validation:

  • git diff --check
  • pnpm --filter @limitless-angular/angular-compat test
  • pnpm --filter @limitless-angular/release-tools test

[Optional] What gif best describes this PR or how it makes you feel?

N/A

@netlify

netlify Bot commented Jun 21, 2026

Copy link
Copy Markdown

Deploy Preview for limitless-angular-sanity-example canceled.

Name Link
🔨 Latest commit 556d1c8
🔍 Latest deploy log https://app.netlify.com/projects/limitless-angular-sanity-example/deploys/6a377754ac8ea70008c946e0

@pkg-pr-new

pkg-pr-new Bot commented Jun 21, 2026

Copy link
Copy Markdown

Open in StackBlitz

npm i https://pkg.pr.new/@limitless-angular/sanity@79

commit: 556d1c8

@osnoser1
osnoser1 force-pushed the osnoser1/replicate-cianz-pr-32-node-24 branch from 867c8ec to 31b2b5e Compare June 21, 2026 04:54
@osnoser1
osnoser1 merged commit 4fd1cc8 into main Jun 21, 2026
18 checks passed
@osnoser1
osnoser1 deleted the osnoser1/replicate-cianz-pr-32-node-24 branch June 21, 2026 05:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant