[WIP] Introduce pluggable Ref DB backends - #1226
Closed
jamill wants to merge 3 commits into
Closed
Conversation
Member
Author
Member
Author
There was a problem hiding this comment.
This test is currently failing - I am not sure if it is due to an bug the LibGit2Sharp side, or in the libgit2 side.
-
The comments for the unlock call in refdb_backend.h seems like it might not reflect the current implementation? Looking at the code, libgit2 also returns
2in update_target as a value for success in one place, and I am not sure how to interpret it... -
In update_target in transaction.c, there is some logic that is allocating refs. Should these calls instead be targeting the refdb backend?
There was a problem hiding this comment.
How did you go with this? Did you manage to get any further around resolving these issues?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These changes have been sitting around for a while (builds upon a commit from @ethomson from 2013), and I wanted to see about moving this forward. This PR is not complete (yet), but there were some areas I wanted to bring up for discussion.