Set GIT_EOWNER when safe.directory is not configured - #6427
Closed
ehuss wants to merge 1 commit into
Closed
Conversation
Contributor
Contributor
Author
|
Oh my, thanks for the heads up! I searched the issue tracker, but I often forget to also search open PRs. I'll go ahead and close. |
Member
|
Sorry, that's my bad. I've been both busy at home and heads down on work for the past few weeks. I'll 👀 this 🔜. Many apologies for the delay. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When there is an ownership violation, and
safe.directoryis not configured, libgit2 will return a somewhat confusing GIT_ENOTFOUND message withconfig value 'safe.directory' was not found. I'm not sure if this was intentional, but I think it is helpful to instead return GIT_EOWNER to indicate the actual underlying error.