Skip to content

Fix missing include - #6277

Merged
ethomson merged 1 commit into
libgit2:mainfrom
cschlack:sys_transport_missing_include
Apr 25, 2022
Merged

Fix missing include#6277
ethomson merged 1 commit into
libgit2:mainfrom
cschlack:sys_transport_missing_include

Conversation

@cschlack

@cschlack cschlack commented Apr 16, 2022

Copy link
Copy Markdown
Contributor

#include <git2/sys/transport.h> leads to the following error message:

compiling test.c
In file included from test.c:2:
/opt/homebrew/Cellar/libgit2/1.4.2_1/include/git2/sys/transport.h:38:9: error: unknown type name 'git_remote_connect_options'
                const git_remote_connect_options *connect_opts);
                      ^

git_remote_connect_options is defined in git2/remote.h

Including "git2/remote.h" in include/git2/sys/transport.h fixes the issue

@ethomson

ethomson commented Apr 25, 2022

Copy link
Copy Markdown
Member

Good catch, thanks!

@ethomson
ethomson merged commit a1c94e9 into libgit2:main Apr 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

cleanup

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@cschlack @ethomson