remote: Delete a now-inexistent API declaration - #6276
Merged
ethomson merged 1 commit intoApr 25, 2022
Conversation
6fc6eeb replaced the remote options with `git_remote_connect_options`. The function definitions were removed, but one function declaration remained, causing linker errors if one tried to use it. This change removes the declaration of `git_transport_smart_proxy_option` to better reflect reality.
lhchavez
force-pushed
the
delete-git_transport_smart_proxy_options
branch
from
April 14, 2022 14:21
7b8c22f to
88f2438
Compare
Member
|
Oops, good catch. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
6fc6eeb replaced the remote options
with
git_remote_connect_options. The function definitions wereremoved, but one function declaration remained, causing linker errors if
one tried to use it.
This change removes the declaration of
git_transport_smart_proxy_optionto better reflect reality.