mktmp: use fchmod for changing mode - #6160
Closed
boretrk wants to merge 1 commit into
Closed
Conversation
Contributor
Author
|
#5350 is probably a better option |
Member
|
I think that I'm happy with #5350 if we stop rolling our own temp names. It makes me a shade uneasy. |
Contributor
Author
|
I think there is a reluctance to use tempnam() based on the following text from The Open Group Base Specifications Issue 7
An alternative could be using tmpnam() for the random part of the string since we build the prefix anyway. It is also marked obsolescent but since it is part of C99 it is unlikely to not be supported. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Using fchmod in cases where we have a filehandle allows PosixLib to work around the issue with being unable to change mode on open files on AmigaOS.
It also seems to me like it would be the better option for other systems too.
Unfortunately it seems like Windows doesn't have a direct equivalent?