Skip to content

azure: tests: re-run flaky proxy tests - #5381

Merged
pks-t merged 2 commits into
libgit2:masterfrom
pks-t:pks/tests-flaky-proxy
Feb 6, 2020
Merged

azure: tests: re-run flaky proxy tests#5381
pks-t merged 2 commits into
libgit2:masterfrom
pks-t:pks/tests-flaky-proxy

Conversation

@pks-t

@pks-t pks-t commented Feb 4, 2020

Copy link
Copy Markdown
Member

The proxy tests regularly fail in our CI environment. Unfortunately,
this is expected due to the network layer. Thus, let's re-try the proxy
tests up to five times in case they fail.

pks-t added 2 commits February 4, 2020 11:26
The proxy tests regularly fail in our CI environment. Unfortunately,
this is expected due to the network layer. Thus, let's re-try the proxy
tests up to five times in case they fail.
While we already do have logic to re-run flaky tests, the FAILED
variable currently does not get reset to "0". As a result, successful
reruns will still cause the test to be registered as failed.

Fix this by resetting the variable accordingly.
@pks-t

pks-t commented Feb 4, 2020

Copy link
Copy Markdown
Member Author

Added another fix. Reruns wouldn't count as successful due to us not resetting FAILED. Hopefully this gets our CI stable again, it's been failing a lot recently. /cc @ethomson

@pks-t
pks-t merged commit bd6b1c4 into libgit2:master Feb 6, 2020
@pks-t
pks-t deleted the pks/tests-flaky-proxy branch February 6, 2020 05:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant