Correctly write to missing locked global config - #5023
Merged
pks-t merged 1 commit intoMay 2, 2019
Conversation
implausible
added a commit
to nodegit/nodegit
that referenced
this pull request
Mar 20, 2019
Opening a default config when ~/.gitconfig doesn't exist, locking it, and attempting to write to it causes an assertion failure. Treat non-existent global config file content as an empty string.
ianhattendorf
force-pushed
the
fix/lock_missing_global_config
branch
from
April 30, 2019 00:21
21db791 to
e44110d
Compare
Contributor
Author
|
Good to hear, just pushed up the rebased changes. |
Contributor
Author
|
/rebuild |
|
Okay, @ianhattendorf, I started to rebuild this pull request as build #1861. |
Member
|
Thanks for resolving the conflict and thanks for your fix in general! |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Opening a default config when ~/.gitconfig doesn't exist, locking it,
and attempting to write to it causes an assertion failure.
Treat non-existent global config file content as an empty string.