refs: traverse symlinked directories - #4455
Merged
Merged
Conversation
Native Git allows symlinked directories under .git/refs. This change allows libgit2 to also look for references that live under symlinked directories. Signed-off-by: Andy Doan <andy@opensourcefoundries.com>
Perform some error checking when examining symlink directories.
Ensure that we can recurse into directories via symbolic links.
|
thanks for the Chistmas gift! |
Member
|
Cool 👍 I like the test in particular |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When enumerating the references in the loose refs storage area, we should traverse symlinked directories. eg, if I create
refs/heads/foo->/tmp/refs, and create a loose ref/tmp/refs/asdf, then I should be able to resolverefs/heads/foo/asdf.This is @doanac's change in #4388, with some minor cleanups for error checking and adding a test to easily validate this locally. I'm opening a PR to put it through the paces on the CI machines.